[
https://issues.apache.org/jira/browse/CURATOR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107486#comment-14107486
]
ASF GitHub Bot commented on CURATOR-144:
----------------------------------------
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/41#discussion_r16621573
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
@@ -65,6 +65,106 @@
{
private static final Logger LOG =
LoggerFactory.getLogger(TreeCache.class);
+ public static final class Builder {
+ private final CuratorFramework client;
+ private final String path;
+ private boolean cacheData = true;
+ private boolean dataIsCompressed = false;
+ private CloseableExecutorService executorService = null;
+
+ private Builder(CuratorFramework client, String path) {
+ this.client = client;
+ this.path = path;
--- End diff --
Please use ```PathUtils.validatePath``` to make sure that the path is valid
before accepting it.
> TreeCache should use a builder for advanced options
> ---------------------------------------------------
>
> Key: CURATOR-144
> URL: https://issues.apache.org/jira/browse/CURATOR-144
> Project: Apache Curator
> Issue Type: Improvement
> Components: Recipes
> Reporter: Scott Blum
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
