Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/51#discussion_r19614037
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/PathChildrenCache.java
---
@@ -382,6 +383,11 @@ public void close() throws IOException
connectionStateListener = null;
childrenWatcher = null;
dataWatcher = null;
+
+ synchronized (backgroundTaskMonitor) {
--- End diff --
I'm still not sure I follow the logic, sorry. What is the benefit of making
the close method wait before returning? It seems like you would need to acquire
the lock earlier in the method to have an impact on control flow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
