[
https://issues.apache.org/jira/browse/CURATOR-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222010#comment-14222010
]
ASF GitHub Bot commented on CURATOR-160:
----------------------------------------
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/53#discussion_r20757865
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/Configurable.java
---
@@ -0,0 +1,29 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.curator.framework.api;
+
+public interface Configurable<T> {
+
+ /**
+ * Sets the configuration version to use.
+ * @param config The version of the configuration.
+ * @throws Exception
+ */
+ Ensembleable<T> fromConfig(long config) throws Exception;
--- End diff --
It's optional. Here's the Javadoc comment:
```
* @param fromConfig
* version of the current configuration (optional -
causes reconfiguration to throw an exception if configuration is no longer
current)
```
Also, in the ZK code,
```
long configId = reconfigRequest.getCurConfigId();
if (configId != -1 &&
configId!=lzks.self.getLastSeenQuorumVerifier().getVersion()){
```
> Support Dynamic Reconfig
> ------------------------
>
> Key: CURATOR-160
> URL: https://issues.apache.org/jira/browse/CURATOR-160
> Project: Apache Curator
> Issue Type: Sub-task
> Reporter: Jordan Zimmerman
> Assignee: Ioannis Canellos
> Fix For: 3.0.0
>
>
> ZooKeeper 3.5.0 added a new feature "Dynamic Reconfiguration". Curator needs
> to support this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
