[GitHub] curator pull request: Use Curator in thread names.

[dragonsinth]

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/60#discussion_r22500645
  
    --- Diff: 
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorTempFrameworkImpl.java
 ---
    @@ -98,7 +99,15 @@ private synchronized void openConnectionIfNeeded() 
throws Exception
             if ( cleanup == null )
             {
                 ThreadFactory threadFactory = factory.getThreadFactory();
    -            cleanup = (threadFactory != null) ? 
Executors.newScheduledThreadPool(1, threadFactory) : 
Executors.newScheduledThreadPool(1);
    +
    --- End diff --
    
    But @Randgalt can you verify that this should be non-daemon?  Just 
wondering if it's a latent bug here that this will tie up process exit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---