Damn - I screwed up. Sorry about that.
On January 13, 2015 at 12:47:38 AM, Cameron McKenzie ([email protected]) wrote: I think the implementation of CURATOR-111 is actually a bit bogus. The way that the two authorization() methods are handled is a bit inconsistent, and reusing the same CuratorFrameworkBuilder causes issues apparently which is what's causing the tests to fail. I have fixed up the issue and created a PR off the CURATOR-111 branch. This works on the assumption that multiple calls to authorization() should overwrite each other (which is what the previous implementation only supporting a single authorization would have done). cheers On Tue, Jan 13, 2015 at 3:53 PM, Cameron McKenzie <[email protected]> wrote: > Actually, doesn't work on master either. Looks like it was broken as part > of CURATOR-111 > > On Tue, Jan 13, 2015 at 3:00 PM, Cameron McKenzie <[email protected]> > wrote: > >> I seem to keep getting a failure in: >> >> Failed tests: >> TestFramework.testCreateACL:254 Should have failed with auth exception >> >> Is anyone else having this problem? I tested the master branch this >> morning when I merged in CURATOR-179 and wasn't having this issue. >> cheers >> >> On Tue, Jan 13, 2015 at 2:14 PM, Jordan Zimmerman <[email protected]> >> wrote: >> >>> Hello, >>> >>> This is the vote for Apache Curator version 2.7.1 >>> >>> *** Please download, test and vote within approx. 72 hours >>> >>> Note that we are voting upon the source (tag) and binaries are >>> provided for convenience. >>> >>> Link to release notes: >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12328938 >>> >>> >>> Staging repo: >>> https://dist.apache.org/repos/dist/dev/curator/2.7.1/ >>> >>> Binary artifacts: >>> https://repository.apache.org/content/repositories/orgapachecurator-1008/ >>> >>> The tag to be voted upon: >>> >>> https://git-wip-us.apache.org/repos/asf?p=curator.git;a=tag;h=0bc196eef2f4f0ce8a15032b73bd80cb67ad7a36 >>> >>> >>> Curator's KEYS file containing PGP keys we use to sign the release: >>> http://www.apache.org/dist/curator/KEYS >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >> >> >
