Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/72#discussion_r28801137
--- Diff:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceDiscoveryImpl.java
---
@@ -207,9 +207,15 @@ protected void
internalRegisterService(ServiceInstance<T> service) throws Ex
{
try
{
- CreateMode mode = (service.getServiceType() ==
ServiceType.DYNAMIC) ? CreateMode.EPHEMERAL : CreateMode.PERSISTENT;
-
client.create().creatingParentsIfNeeded().withMode(mode).forPath(path, bytes);
- isDone = true;
+ synchronized(service) {
+ // Check that the service didn't get deleted while we
were reconnecting
+ if (services.containsKey(service.getId()))
--- End diff --
Why is this needed? The test passes without this and logically it seems
unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
