Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/56#discussion_r30088312
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/RemoveWatchesBuilderImpl.java
---
@@ -0,0 +1,214 @@
+package org.apache.curator.framework.imps;
--- End diff --
I don't think that this is necessarily true is it? We don't want to remove
the Watcher reference itself because it may still be watching other paths. If
it is no longer referenced then the WeakReference in the NamespaceWatcherMaps
internal cache should handle this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
