Jordan, I noticed that in CURATOR-217 you fixed up the license headers of a bunch of the files that were committed as part of CURATOR-161. I don't want to merge CURATOR-161 back to the 3.0 branch without the headers as I think it will break the build. So, what's the best way forward? Do you just want to merge CURATOR-217 back to the 3.0 branch given that it already contains all of the CURATOR-161 changes? cheers
On Wed, May 20, 2015 at 9:23 AM, Jordan Zimmerman < [email protected]> wrote: > https://github.com/apache/curator/pull/82 > > > > On May 19, 2015 at 4:18:36 PM, Cameron McKenzie ([email protected]) > wrote: > > Thanks Jordan, > Will have a look at the PR. > cheers > > On Wed, May 20, 2015 at 9:17 AM, Jordan Zimmerman < > [email protected]> wrote: > >> I’ll have a look. Also, I already started on integrating watcher >> removal as I have strong ideas on it. Here’s the current PR: >> https://github.com/apache/curator/pull/80 >> >> <https://github.com/apache/curator/pull/80> >> - <https://github.com/apache/curator/pull/80>JZ >> >> >> On May 19, 2015 at 4:06:03 PM, Cameron McKenzie ([email protected]) >> wrote: >> >> Guys, >> If anyone's got a spare few minutes could they please review the final >> changes to CURATOR-161. If we're happy with the implementation then I'll >> merge into the 3.0 branch and then start work on getting the recipes to >> use >> the watcher removal stuff. >> cheers >> Cam >> >> >
