Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/83#discussion_r32594090
--- Diff:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
---
@@ -66,6 +68,18 @@
cache.getListenable().addListener(this);
}
+ ServiceCacheImpl(ServiceDiscoveryImpl<T> discovery, String name,
CloseableExecutorService executorService)
--- End diff --
Please have the other ctor call this one. You may need to introduce a third
private ctor. i.e. only 1 ctor should have code. The others should forward to
the 1 with code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
