Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/78#discussion_r32885316
--- Diff:
curator-client/src/main/java/org/apache/curator/ensemble/exhibitor/ExhibitorEnsembleProvider.java
---
@@ -301,7 +301,7 @@ else if ( port != thePort )
values.putAll(decodeExhibitorList(encoded));
done = true;
}
- catch ( Throwable e )
+ catch ( Exception e )
--- End diff --
NPE still gets caught. If OOM is thrown, does it really make sense to
retry? That's usually a pretty drastic condition and very often the JVM is not
actually in a recoverable state. The OOM can be thrown because of a different
thread going wonky, and we have no way to clean up the resources it was using.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
