[ 
https://issues.apache.org/jira/browse/CURATOR-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609372#comment-14609372
 ] 

ASF GitHub Bot commented on CURATOR-222:
----------------------------------------

Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/79#issuecomment-117380664
  
    @Randgalt, looks good to me. A couple of minor things for discussion.
    1.) Can the internal EnsurePath stuff in NamespaceImpl be replaced with the 
new container stuff?
    2.) When executing creatingContainerParentsIfNeeded(), I was wondering if 
some sort of warning log should be generated if the parents already exist and 
are not container nodes? I'm just thinking of the case where you try and create 
a hierachy of nodes and some of them already exist as persistent nodes. Maybe 
it's just up to the user to remove any existing parents if this is important?


> Support Container Nodes
> -----------------------
>
>                 Key: CURATOR-222
>                 URL: https://issues.apache.org/jira/browse/CURATOR-222
>             Project: Apache Curator
>          Issue Type: New Feature
>          Components: Client, Framework, Recipes
>    Affects Versions: 2.8.0
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>             Fix For: 2.9.0
>
>
> ZooKeeper will most likely add support for "Container" nodes per 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2163 - Curator must support 
> this feature
> * Backwards compatible to 3.4.6. If Containers are available, they’re used in 
> all recipes that create parent nodes.
> * The use of EnsurePath is now deprecated



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to