Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/93#discussion_r35294429
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentEphemeralNode.java
---
@@ -233,8 +236,15 @@ else if ( event.getResultCode() ==
KeeperException.Code.OK.intValue() )
{
path = event.getName();
}
+ else if ( event.getResultCode() ==
KeeperException.Code.NOAUTH.intValue() )
+ {
+ log.warn("Client does not have authorisation to write
ephemeral node at path {}", path);
--- End diff --
Maybe we should just log an error and stop processing for any code that is
not in RetryLoop.shouldRetry()? I was just trying to minimise the impact of the
change as it was previously just handling the NodeExists and OK cases and
retrying everything else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
