Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/97#discussion_r38379208
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java
---
@@ -240,27 +248,37 @@ private void processEvents()
{
try
{
- while ( !Thread.currentThread().isInterrupted() )
+ while ( !Thread.currentThread().isInterrupted() &&
(state.get() == State.STARTED) )
{
- final ConnectionState newState = eventQueue.take();
-
- if ( listeners.size() == 0 )
+ int pollMaxMs = (sessionTimeoutMs * 2) / 3; // 2/3 of
session timeout
--- End diff --
This is the configured session timeout MS. Will this cause issues if the
negotiated timeout is different?
I guess it just means that it will potentially take 4/3 * configured
session timeout to determine if the session has timed out during network
partition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
