[
https://issues.apache.org/jira/browse/CURATOR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909024#comment-14909024
]
ASF GitHub Bot commented on CURATOR-265:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/108
[CURATOR-265] Dynamic Reconfig APIs needs some work
* Completely re-wrote the tests
* The APIs weren't correct for all permutations
* adding() API was not correct. In ZK, it's called "newMembers" and is
mutually exclusive with join/leave
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 2c0fca86ca3c25c9777e1b5c3bb3eea6cb0be8da
Author: randgalt <[email protected]>
Date: 2015-09-26T00:14:53Z
interim work - updated APIs make sure old tests work
commit 4c3c8377935f8ae2c0f24c4a1010cf4bdef4e297
Author: randgalt <[email protected]>
Date: 2015-09-26T00:22:10Z
Merge branch 'CURATOR-3.0' into CURATOR-265
Conflicts:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java
commit d42ef172e57af17ed42d7c2c4e2d9a7a0c520f3c
Author: randgalt <[email protected]>
Date: 2015-09-26T02:07:44Z
wip - adding() API was misnamed. Also, it's mutually exclusive with
join/leave
commit 36ddd58a31045addfd9d984353956f7a99c09221
Author: randgalt <[email protected]>
Date: 2015-09-26T02:49:12Z
finalized the changes and removed old classes
----
> Dynamic Reconfig APIs needs some work and more accurate testing
> ---------------------------------------------------------------
>
> Key: CURATOR-265
> URL: https://issues.apache.org/jira/browse/CURATOR-265
> Project: Apache Curator
> Issue Type: Bug
> Components: Recipes
> Affects Versions: 3.0.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.0.0
>
>
> The new dynamic reconfig APIs don't have all permutations and the tests are
> flakey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
