Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/125#discussion_r49953173
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -257,8 +258,7 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState)
client.start();
- executorService = Executors.newFixedThreadPool(2,
threadFactory); // 1 for listeners, 1 for background ops
-
+ executorService =
Executors.newSingleThreadScheduledExecutor(threadFactory);
--- End diff --
Is there a reason that this has gone from a 2 thread pool to a single
thread pool? Looking at the old code, it would seem that only 1 is used (for
the background loop), but just double checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---