[
https://issues.apache.org/jira/browse/CURATOR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105896#comment-15105896
]
ASF GitHub Bot commented on CURATOR-287:
----------------------------------------
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/123#discussion_r50050858
--- Diff:
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentNode.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.curator.framework.recipes.nodes;
+
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.CuratorFrameworkFactory;
+import org.apache.curator.retry.RetryOneTime;
+import org.apache.curator.test.BaseClassForTests;
+import org.apache.curator.test.Timing;
+import org.apache.curator.utils.CloseableUtils;
+import org.apache.zookeeper.CreateMode;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+import java.util.concurrent.TimeUnit;
+
+public class TestPersistentNode extends BaseClassForTests
+{
+ @Test
+ public void testBasic() throws Exception
--- End diff --
Maybe additional tests for the sequential case?
> PersistentEphemeralNode should be generalized to accept all create modes
> ------------------------------------------------------------------------
>
> Key: CURATOR-287
> URL: https://issues.apache.org/jira/browse/CURATOR-287
> Project: Apache Curator
> Issue Type: New Feature
> Components: Recipes
> Affects Versions: 3.0.0, 2.9.1
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Minor
>
> With very little change, PersistentEphemeralNode could work with
> non-ephemeral nodes. There is a good use case for this: permanent nodes that
> must always exist with some data. It's actually a pain to do this manually
> with ZK.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
