Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/131#discussion_r52203476
  
    --- Diff: 
curator-framework/src/main/java/org/apache/curator/framework/imps/NamespaceWatcher.java
 ---
    @@ -75,4 +89,53 @@ else if ( curatorWatcher != null )
                 }
             }
         }
    +
    +    // specialized equals()/hashCode() that makes this instance equal to 
the actual watcher
    +
    +    @Override
    +    public boolean equals(Object o)
    +    {
    +        if ( this == o )
    +        {
    +            return true;
    +        }
    +        if ( o == null )
    +        {
    +            return false;
    +        }
    +
    +        if ( getClass() == o.getClass() )
    +        {
    +            NamespaceWatcher watcher = (NamespaceWatcher)o;
    +
    +            if ( !unfixedPath.equals(watcher.getUnfixedPath()) )
    +            {
    +                return false;
    +            }
    +
    +            //noinspection SimplifiableIfStatement
    +            if ( actualWatcher != null ? 
!actualWatcher.equals(watcher.actualWatcher) : watcher.actualWatcher != null )
    +            {
    +                return false;
    +            }
    +            return curatorWatcher != null ? 
curatorWatcher.equals(watcher.curatorWatcher) : watcher.curatorWatcher == null;
    +        }
    +
    --- End diff --
    
    I don't think it can actually happen as my main concern is inside ZK. But, 
for completeness it should be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to