[ 
https://issues.apache.org/jira/browse/CURATOR-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249985#comment-15249985
 ] 

Jordan Zimmerman commented on CURATOR-317:
------------------------------------------

Rule #1 - Comments Lie! :D Thanks for the PR. We'll look when we can.

> Deprecation comment suggests code that is not equivalent
> --------------------------------------------------------
>
>                 Key: CURATOR-317
>                 URL: https://issues.apache.org/jira/browse/CURATOR-317
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Jorge Montero
>            Priority: Trivial
>
> An old deprecation (from 2012) recommended replacing 
> withProtectedEphemeralSequential() with 
> withProtection().withMode(CreateMode.PERSISTENT_SEQUENTIAL), which does not 
> do the same thing! Anyone making that replacement will get persistent nodes 
> instead of ephemeral modes, which can cause all kinds of trouble (it 
> definitely did for us!)
> It should be replaced with code that actually does the same thing as the old 
> implementation:                          
> .withProtection().withMode(CreateMode.EPHEMERAL_SEQUENTIAL)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to