[
https://issues.apache.org/jira/browse/CURATOR-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251051#comment-15251051
]
ASF GitHub Bot commented on CURATOR-299:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/145
[CURATOR-299] WatcherRemovalManager must be updated when there's an
exception, retry, etc.
If there's an exeption, retries exceeded, etc., the watcher was still being
stored in WatcherRemovalManager thus causing it to be incorrectly removed. This
fix removes the watch from the WatcherRemovalmanager on exceptions, retries
exceeded, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit b1d2198a75d6e01b48789635ba648bedc542c439
Author: randgalt <[email protected]>
Date: 2016-04-21T01:12:31Z
If there's an exeption, retries exceeded, etc., the watcher was still being
stored in WatcherRemovealManager thus causing it to be incorrectly removed.
This fix removes the watch from the WatcherRemovalmanager on exceptions,
retries exceeded, etc.
commit e76eb590fddb5b363b3d40b76908d40f2a89ffc7
Author: randgalt <[email protected]>
Date: 2016-04-21T01:13:42Z
Merge branch 'CURATOR-3.0' into CURATOR-299
----
> Copious "Failed to find watcher" log messages when closing Curator 3.0 recipes
> ------------------------------------------------------------------------------
>
> Key: CURATOR-299
> URL: https://issues.apache.org/jira/browse/CURATOR-299
> Project: Apache Curator
> Issue Type: Bug
> Components: Recipes
> Affects Versions: 3.0.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.1.1
>
>
> [2016-02-01 14:49:47,005][ERROR][org.apache.zookeeper.ClientCnxn] Failed to
> find watcher!
> org.apache.zookeeper.KeeperException$NoWatcherException: KeeperErrorCode = No
> such watcher for /zookeeper/config
> at
> org.apache.zookeeper.ZooKeeper$ZKWatchManager.containsWatcher(ZooKeeper.java:377)
> ~[zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at
> org.apache.zookeeper.ZooKeeper$ZKWatchManager.removeWatcher(ZooKeeper.java:252)
> ~[zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at
> org.apache.zookeeper.WatchDeregistration.unregister(WatchDeregistration.java:58)
> ~[zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at org.apache.zookeeper.ClientCnxn.finishPacket(ClientCnxn.java:712)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at org.apache.zookeeper.ClientCnxn.access$1500(ClientCnxn.java:97)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at
> org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:948)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at
> org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:99)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1236)
> [zookeeper-3.5.1-alpha.jar:3.5.1-alpha-1693007]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
