[
https://issues.apache.org/jira/browse/CURATOR-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275676#comment-15275676
]
ASF GitHub Bot commented on CURATOR-314:
----------------------------------------
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/141#discussion_r62436654
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/GroupMember.java
---
@@ -75,6 +119,7 @@ public void start()
try
{
cache.start();
+ cache.getListenable().addListener(childrenCacheListener);
--- End diff --
Why not add a proxy listener getListenable()? I need to think about this.
Does this single listener correctly proxy all behaviors from getListenable()?
> Listenable support for GroupMember recipe
> -----------------------------------------
>
> Key: CURATOR-314
> URL: https://issues.apache.org/jira/browse/CURATOR-314
> Project: Apache Curator
> Issue Type: Improvement
> Components: Recipes
> Reporter: Shivram Khandeparker
>
> The GroupMember recipe currently doesn't provide any membership change
> events. I wanted this feature in my project and I've implemented it by making
> a copy of GroupMember in my project and adding the necessary classes and
> interfaces. I wanted to contribute this back to curator
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
