[
https://issues.apache.org/jira/browse/CURATOR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Liegeon closed CURATOR-350.
-----------------------------------
Resolution: Invalid
Thinking more about, it does not make any sense.
Multiple watcher share the same service. Closing it in one watcher is wrong
> Allow to close executor service on shutdown
> -------------------------------------------
>
> Key: CURATOR-350
> URL: https://issues.apache.org/jira/browse/CURATOR-350
> Project: Apache Curator
> Issue Type: Improvement
> Reporter: Olivier Liegeon
> Assignee: Jordan Zimmerman
>
> In Issue 251, we got the ability to create a ChildrenCache and passing an
> ExecutorService.
> This change does allow to close this service when closing the childrenCache.
> This should be a parameter, false by default to keep current behavior
> in {{CloseableExecutorService}}
> {code}
> /**
> * @param executorService the service to decorate
> */
> public CloseableExecutorService(ExecutorService executorService)
> {
> this(executorService, false);
> }
> {code}
> {code}
> if (shutdownOnClose) {
> executorService.shutdownNow();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
