[
https://issues.apache.org/jira/browse/CURATOR-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524355#comment-15524355
]
ASF GitHub Bot commented on CURATOR-349:
----------------------------------------
Github user cammckenzie commented on the issue:
https://github.com/apache/curator/pull/165
I've had a bit more of a look and I think that the changes are OK. As you
mentioned, the changes are only to internal classes. There is a loss of
granularity (The TimeTrace was using nanos while your new implementation is
using millis), but I doubt that this is an issue in practice. So, I'm happy
with the changes.
@Randgalt is away at the moment, but I think that he should review it when
he returns.
> Expose extra metrics in TracerDriver
> ------------------------------------
>
> Key: CURATOR-349
> URL: https://issues.apache.org/jira/browse/CURATOR-349
> Project: Apache Curator
> Issue Type: Improvement
> Components: Framework
> Reporter: Fangmin Lv
>
> Currently, the TracerDriver exposed the latency of ZK operations, in
> multi-tenant environment, extra metrics are required to help tracing and
> monitoring:
> * the bytes being sent and received, so we can monitor the client usage
> scenarios.
> * which ensemble participant the client is talking to, used to find out the
> problematic Zk server when the issue happened.
> * the z-node path, to easily find out which z-node caused the problem, like
> high load, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
