[
https://issues.apache.org/jira/browse/CURATOR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631618#comment-15631618
]
ASF GitHub Bot commented on CURATOR-351:
----------------------------------------
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/171#discussion_r86286940
--- Diff:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestTtlNodes.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.curator.framework.imps;
+
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.CuratorFrameworkFactory;
+import org.apache.curator.framework.api.BackgroundCallback;
+import org.apache.curator.framework.api.CuratorEvent;
+import org.apache.curator.retry.RetryOneTime;
+import org.apache.curator.test.BaseClassForTests;
+import org.apache.curator.test.Timing;
+import org.apache.zookeeper.CreateMode;
+import org.testng.Assert;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+import java.util.concurrent.CountDownLatch;
+
+public class TestTtlNodes extends BaseClassForTests
+{
+ @BeforeMethod
+ @Override
+ public void setup() throws Exception
+ {
+ System.setProperty("znode.container.checkIntervalMs", "1");
+ super.setup();
+ }
+
+ @AfterMethod
+ @Override
+ public void teardown() throws Exception
+ {
+ super.teardown();
+ System.clearProperty("znode.container.checkIntervalMs");
+ }
+
+ @Test
+ public void testBasic() throws Exception
+ {
+ try ( CuratorFramework client =
CuratorFrameworkFactory.newClient(server.getConnectString(), new
RetryOneTime(1)) )
+ {
+ client.start();
+
+
client.create().withTtl(10).creatingParentsIfNeeded().withMode(CreateMode.PERSISTENT_WITH_TTL).forPath("/a/b/c");
+ Thread.sleep(20);
--- End diff --
I assume that client should get a 'removed' event when the node times out
and gets removed by ZK? If so, wouldn't it be less error prone to wait on a
latch and checking that the node was deleted within 10 +- some fudge factor
rather than just sleeping?
> ZOOKEEPER-2169 will add support TTL Nodes
> -----------------------------------------
>
> Key: CURATOR-351
> URL: https://issues.apache.org/jira/browse/CURATOR-351
> Project: Apache Curator
> Issue Type: New Feature
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.2.1
>
>
> ZOOKEEPER-2169 will add support TTL Nodes. Upgrade the Curator DSL to support
> TTLs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
