GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/190
[CURATOR-200] Shade Guava into Curator
Shaded Guava into Curator Client (and Curator Test) so that it's no longer
an issue for users. This should have been done a long time ago. Unfortunately,
com.google.common.base.Function, com.google.common.base.Predicate and
com.google.common.reflect.TypeToken are in Curator's public API so those 3
classes are NOT shaded. However, this won't be a problem because there's no
reason to think that Guava will change or remove these basic interfaces.
NOTE: I've tested this by creating a temp project that uses Guava 21.0-rc2.
When used with Curator 2.11.1 I get a NoSuchMethodError. When used with this
new shaded version of Curator there are no errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-200
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit fb277f9601411427dee7d26dd2be76941d38c0c3
Author: randgalt <[email protected]>
Date: 2017-01-08T00:59:07Z
Shaded Guava into Curator Client (and Curator Test) so that it's no longer
an issue for users. This should have been done a long time ago. Unfortunately,
com.google.common.base.Function, com.google.common.base.Predicate and
com.google.common.reflect.TypeToken are in Curator's public API so those 3
classes are NOT shaded. However, this won't be a problem because there's no
reason to think that Guava will change or remove these basic interfaces
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
