[
https://issues.apache.org/jira/browse/CURATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810024#comment-15810024
]
ASF GitHub Bot commented on CURATOR-375:
----------------------------------------
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/186#discussion_r95088443
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
@@ -485,7 +485,6 @@ private String protectedPathInForeground(String
adjustedPath, byte[] data) throw
}
catch ( Exception e)
{
- ThreadUtils.checkInterrupted(e);
--- End diff --
Won't the removal of this call mean that the thread will not be marked as
interrupted unless the caller catches the exception and resets the value
themselves? This code is called from many recipes and can also be called
explicitly by users Curator code. I would think that there's great potential to
break code here, unless I'm missing something.
> Fix thread interruption being reported twice
> --------------------------------------------
>
> Key: CURATOR-375
> URL: https://issues.apache.org/jira/browse/CURATOR-375
> Project: Apache Curator
> Issue Type: Bug
> Affects Versions: 2.11.1
> Reporter: Simon Cooper
> Assignee: Jordan Zimmerman
>
> When a curator operation thread is interrupted, some classes
> ({{PersistentNode}} {{ConnectionState}} primarily) report the interruption in
> two ways at the same time - by re-marking the thread interruption status
> *and* throwing {{InterruptedException}} - this makes it look like the thread
> has been interrupted twice, rather than once.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
