[
https://issues.apache.org/jira/browse/CURATOR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815462#comment-15815462
]
ASF GitHub Bot commented on CURATOR-311:
----------------------------------------
GitHub user oza opened a pull request:
https://github.com/apache/curator/pull/193
[CURATOR-311] SharedValue could hold stall data when quourm membership
changes
Adding error handling to refresh stale data when stateChanged is called.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oza/curator CURATOR-311
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit 807a8e32b0173b1e2e35ce98e6865e3232da3129
Author: Tsuyoshi Ozawa <[email protected]>
Date: 2017-01-10T16:31:25Z
CURATOR-311 - SharedValue could hold stall data when quourm membership
changes
----
> SharedValue could hold stall data when quourm membership changes
> ----------------------------------------------------------------
>
> Key: CURATOR-311
> URL: https://issues.apache.org/jira/browse/CURATOR-311
> Project: Apache Curator
> Issue Type: Bug
> Components: Recipes
> Affects Versions: 3.1.0
> Environment: Linux
> Reporter: Jian Fang
>
> We run a Zookeeper 3.5.1-alpha quorum on EC2 instances and the quorum members
> could be changed, for example, one peer could be replaced by a new EC2
> instance due to EC2 instance termination. We use Apache Curator 3.1.0 as the
> zookeeper client. During our testing, we found the SharedValue data structure
> could hold stall data during and after one peer is replaced and thus led to
> the system failure.
> We look into the SharedValue code. Seems it always returns the value from an
> in-memory reference variable and the value is only updated by a watcher. If
> for any reason, the watch is lost, then the value would never get a chance to
> be updated again.
>
> Right now, we added a connection state listener to force SharedValue to call
> readValue(), i.e., read the data from zookeeper directly, if the connection
> state has been changed to RECONNECTED to work around this issue.
> It would be great if this issue could be fixed in Curator directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
