I love Maven :D https://rule1.quora.com/Use-Maven-Not-Gradle <https://rule1.quora.com/Use-Maven-Not-Gradle>
-JZ > On Jan 15, 2017, at 12:36 PM, Scott Blum <dragonsi...@gmail.com> wrote: > > I glanced at the maven shade one, seemed okay. Maven is such a shit ball > though that the rule of thumb is that of the output is right, it's right. > Lol > > On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jor...@jordanzimmerman.com> > wrote: > >> Thanks Cameron >> >>> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mckenzie....@gmail.com> >> wrote: >>> >>> I've been looking at the CURATOR-99 PR, but it's going to take a while, >>> it's quite a large PR. >>> >>> The Maven shading one, I'm not going to be much use reviewing as my >>> knowledge of Maven is very limited. >>> cheers >>> >>> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman < >>> jor...@jordanzimmerman.com> wrote: >>> >>>> Hello Folks, >>>> >>>> The following Pull Requests could really use review. If you have a >> moment >>>> it would be appreciated: >>>> >>>> >>>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/ >>>> curator/pull/190 >>>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/ >>>> curator/pull/189 >>>> >>>> >>>> -Jordan >>>> >> >>