Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/197#discussion_r103350579
--- Diff:
curator-client/src/main/java/org/apache/curator/ConnectionState.java ---
@@ -283,12 +300,19 @@ private boolean checkState(Event.KeeperState state,
boolean wasConnected)
new EventTrace(state.toString(), tracer.get(),
getSessionId()).commit();
}
- if ( checkNewConnectionString &&
zooKeeper.hasNewConnectionString() )
+ return isConnected;
+ }
+
+ private void handleState(Event.KeeperState state)
+ {
+ if (state == Event.KeeperState.Expired)
+ {
+ handleExpiredSession();
--- End diff --
It's `handleState()` that I'm concerned about. When `state ==
Event.KeeperState.Expired` the `zooKeeper.hasNewConnectionString()` isn't
called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
