[ 
https://issues.apache.org/jira/browse/CURATOR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996090#comment-15996090
 ] 

ASF GitHub Bot commented on CURATOR-407:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/218#discussion_r114693246
  
    --- Diff: 
curator-x-async/src/main/java/org/apache/curator/x/async/details/AsyncTransactionOpImpl.java
 ---
    @@ -87,10 +87,7 @@ public AsyncTransactionCreateBuilder create()
                 @Override
                 public AsyncPathAndBytesable<CuratorOp> withOptions(CreateMode 
createMode, List<ACL> aclList, boolean compressed)
                 {
    -                this.createMode = Objects.requireNonNull(createMode, 
"createMode cannot be null");
    -                this.aclList = aclList;
    -                this.compressed = compressed;
    -                return this;
    +                return withOptions(createMode, aclList, compressed, ttl);
                 }
    --- End diff --
    
    Ok, looks good to me.


> Create Transaction DSL is missing TTL support
> ---------------------------------------------
>
>                 Key: CURATOR-407
>                 URL: https://issues.apache.org/jira/browse/CURATOR-407
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 3.3.0
>            Reporter: Jordan Zimmerman
>             Fix For: 3.4.0
>
>
> TransactionCreateBuilder is missing TTL support. i.e. you should be able to 
> specify a TTL when doing a create transaction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to