[
https://issues.apache.org/jira/browse/CURATOR-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998806#comment-15998806
]
ASF GitHub Bot commented on CURATOR-409:
----------------------------------------
GitHub user srdo opened a pull request:
https://github.com/apache/curator/pull/219
CURATOR-409: Fix unintentional override of getQuorumPeer in TestingQu…
…orumPeerMain
https://issues.apache.org/jira/browse/CURATOR-409
I don't know if QuorumPeer is useful to users of curator-test, but
getQuorumPeer isn't used anywhere in the code, so if it is possible to remove
it entirely that's probably a nicer solution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/curator CURATOR-409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #219
----
commit 956176629f5cc9d7c53b52068e4ebdcbdfb86e68
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-05-05T18:44:10Z
CURATOR-409: Fix unintentional override of getQuorumPeer in
TestingQuorumPeerMain
----
> TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta
> -------------------------------------------------------------
>
> Key: CURATOR-409
> URL: https://issues.apache.org/jira/browse/CURATOR-409
> Project: Apache Curator
> Issue Type: Bug
> Components: Tests
> Affects Versions: 3.3.0
> Reporter: Stig Rohde Døssing
>
> Zookeeper 3.5.3 has added a getQuorumPeer method to QuorumPeerMain
> https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194.
> TestingQuorumPeerMain has an identically named method, which is now
> unintentionally overridding the one in the base class.
> This causes TestingCluster to be unusable.
> {code}
> 20:36:41.199 [Thread-1] ERROR org.apache.curator.test.TestingZooKeeperServer
> - From testing server (random state: false) for instance:
> InstanceSpec{dataDirectory=C:\Users\Esran\AppData\Local\Temp\1494009401090-0,
> port=65306, electionPort=65307, quorumPort=65308,
> deleteDataDirectoryOnClose=true, serverId=1, tickTime=-1, maxClientCnxns=-1,
> customProperties={}, hostname=127.0.0.1}
> org.apache.curator.test.InstanceSpec@59c4b497
> java.lang.NullPointerException: null
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:158)
>
> ~[zookeeper-3.5.3-beta.jar:3.5.3-beta-8ce24f9e675cbefffb8f21a47e06b42864475a60]
> at
> org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:150)
> [curator-test-3.3.0.jar:3.3.0]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_73]
> {code}
> The method in TestingQuorumPeerMain should be renamed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
