[ 
https://issues.apache.org/jira/browse/CURATOR-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002821#comment-16002821
 ] 

ASF GitHub Bot commented on CURATOR-411:
----------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/curator/pull/221

    [CURATOR-411] Fix various testing issues

    - disable testMissedDelete - it needs to be re-written
    - overload setState() in TestZooKeeperServer to avoid bogus log message
    - Turn off JMX logging in ZooKeeper
    - TestReconfiguration was messed up by ZK 3.5.3 reconfig changes
    - Added a method to Timing to take from a queue with timeouts and applied 
it to tests that needed it
    - CURATOR-410 and CURATOR-409

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator CURATOR-411

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #221
    
----
commit 872bfb0285dc4807d873b9ee2707b0f6044747f6
Author: randgalt <[email protected]>
Date:   2017-05-08T04:01:45Z

    Added a method to Timing to take from a queue with timeouts and applied it 
to tests that needed it

commit 5407746c37c6ee08bbefe6632e25f5790226180c
Author: randgalt <[email protected]>
Date:   2017-05-08T04:15:40Z

    Merge branch 'master' into CURATOR-411

commit 0d1aa7ed1f3fef2b9cdb1e3a7f15d6e6ae85dac0
Author: randgalt <[email protected]>
Date:   2017-05-08T17:37:06Z

    Have to call setReconfigEnabled(true) and set the super-user Auth to get 
reconfig to work

commit 3fa5143d6692bb18dba0d21a28328de032482d6f
Author: randgalt <[email protected]>
Date:   2017-05-08T17:43:16Z

    connection string cannot be empty

commit 4813b7924ecb6f0a2c4836e3e167e220a35f5314
Author: randgalt <[email protected]>
Date:   2017-05-08T21:29:49Z

    Turn off JMX logging

commit 70588f92e3dc7162f1e0df12ad0c09c92ab86b32
Author: randgalt <[email protected]>
Date:   2017-05-08T21:51:25Z

    extend BaseClassForTests so that retries occur

commit 27ddd8c90042ca7abc667edb63504d081a1ca1b4
Author: randgalt <[email protected]>
Date:   2017-05-09T08:50:35Z

    overload setState() to avoid bogus log message

commit 88d56219e3be026e453a5ef254bee3771d5b018b
Author: randgalt <[email protected]>
Date:   2017-05-09T10:40:50Z

    disable testMissedDelete() for now

----


> Make Tests Great Again
> ----------------------
>
>                 Key: CURATOR-411
>                 URL: https://issues.apache.org/jira/browse/CURATOR-411
>             Project: Apache Curator
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 3.3.0
>            Reporter: Jordan Zimmerman
>
> The current master branch fails many tests and hangs on some. Let's get this 
> fixed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to