[ 
https://issues.apache.org/jira/browse/CURATOR-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027982#comment-16027982
 ] 

Cameron McKenzie commented on CURATOR-411:
------------------------------------------

Can someone explain the testNewMembers() test to me, maybe I'm missing 
something:

>From my reading, a cluster with 5 instances is created, but only 3 of them are 
>started.

The Curator client is created knowing only about the 3 instances that are 
started. When it connects to the cluster it queries the configuration of the 
cluster and finds that there are 5 instances. This much of the test works OK.

The next bit is what seems strange to me. It does a reconfig call to ZK 
withNewMembers, but passes in the existing 3 instances that the client already 
knows about. This seems to cause problems because ZK tries to open a server 
socket on the ports defined in the new connection string, but they are already 
present. See below:

ERROR org.apache.zookeeper.server.NIOServerCnxnFactory  Error reconfiguring 
client port to /0.0.0.0:35841 Address already in use 
[LearnerHandler-/127.0.0.1:47224]
ERROR org.apache.zookeeper.server.quorum.QuorumCnxManager  Exception while 
listening [/0.0.0.0:42569]
java.net.BindException: Address already in use (Bind failed)
        at java.net.PlainSocketImpl.socketBind(Native Method)
        at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:376)
        at java.net.ServerSocket.bind(ServerSocket.java:376)
        at java.net.ServerSocket.bind(ServerSocket.java:330)
        at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener.run(QuorumCnxManager.java:638)

I don't understand what this part of the test is meant to be doing. If it's 
trying to add new members, shouldn't it be binding new ports in the connection 
string being passed to withNewMembers()?


> Make Tests Great Again
> ----------------------
>
>                 Key: CURATOR-411
>                 URL: https://issues.apache.org/jira/browse/CURATOR-411
>             Project: Apache Curator
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 3.3.0
>            Reporter: Jordan Zimmerman
>
> The current master branch fails many tests and hangs on some. Let's get this 
> fixed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to