[
https://issues.apache.org/jira/browse/CURATOR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095175#comment-16095175
]
ASF GitHub Bot commented on CURATOR-425:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/230
[CURATOR-425] ZooKeeper 3.4.x compatibility mode
This PR adds ZooKeeper 3.4 compatibility to the master branch. With this,
we will no longer need the CURATOR-2.0 branch nor two Curator versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 0641243f75d25a92a9ceb811e8e2611a1e95869e
Author: randgalt <[email protected]>
Date: 2017-07-19T17:36:24Z
initial work on ZooKeeper 3.4.x compatibility mode
commit 58bc969fecc01a1947dd272300d4fb305d221ea2
Author: randgalt <[email protected]>
Date: 2017-07-20T06:48:40Z
Basic concept of zk 3.4.x compatibility proven. The Compatibility class
checks for a well-known 3.5 class and sets a static
that advertises whether the ZK lib is 3.4.x or 3.5.x. Then, the code "ifs"
using this static. The major work was emulating
the kill session injection (that emulation is done using reflection) and
testing. The curator-test-zk module runs
the framework and recipe tests but forces ZooKeeper 3.4.x and uses the
Curator 2.x version of curator-test. This
requires a few tricks as the new code uses new methods/classes on the
Curator 3.x version of curator-test. I'll write
a readme documenting how this is done.
commit 242b7011a7b8344f772c1a4497aadf6de16d73f5
Author: randgalt <[email protected]>
Date: 2017-07-20T07:14:10Z
Use the resource plugin to copy the compatibility files instead of adding
the source directory. This seems more compatible
commit 097083c4a2cd2e252c6f3b57e3e837e4a9ecabc9
Author: randgalt <[email protected]>
Date: 2017-07-20T15:53:52Z
TestTreeCache now uses the improved KillSession2 but that results in
different event ordering
commit 20a3db363273429cec80f511a32a737886c6f3c8
Author: randgalt <[email protected]>
Date: 2017-07-20T16:04:51Z
Added some missing deps, fixed some of the tests for zk 3.4 compat and new
KillSession, added a SDummyTest to make Maven happy
commit 96340af1d1525b2c5bf50adccc499c6917ff7563
Author: randgalt <[email protected]>
Date: 2017-07-20T17:17:35Z
need to sleep a bit between setcounts so to avoid missing events
commit 6b6f13f74afa0fe3d8752224c1af82c2709e7f6b
Author: randgalt <[email protected]>
Date: 2017-07-20T17:17:50Z
license
commit d1a650715ab955758369ff2db123bd97577cf826
Author: randgalt <[email protected]>
Date: 2017-07-20T17:35:49Z
read me
commit 89182ed11a8f6ff4fa5ec9cc955ff68241076f5d
Author: randgalt <[email protected]>
Date: 2017-07-20T18:40:30Z
More tests, refined tests and doc
----
> Create ZooKeeper 3.4.x compatibility mode for master branch (Curator 3.x)
> -------------------------------------------------------------------------
>
> Key: CURATOR-425
> URL: https://issues.apache.org/jira/browse/CURATOR-425
> Project: Apache Curator
> Issue Type: Task
> Components: Client, Documentation, Framework, General, Recipes,
> Tests, Website
> Affects Versions: 3.3.0, 2.12.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.4.0
>
>
> Maintaining the CURATOR-2.0 branch is becoming untenable. Investigate if it's
> possible to have a version of Curator 3.x that works with both ZooKeeper
> 3.5.x and ZooKeeper 3.4.x
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
