[ 
https://issues.apache.org/jira/browse/CURATOR-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185768#comment-16185768
 ] 

ASF GitHub Bot commented on CURATOR-432:
----------------------------------------

Github user acoburn commented on the issue:

    https://github.com/apache/curator/pull/237
  
    I actually think the issue here is _not_ with the 
`org.apache.curator/curator-client` bundle (which _is_ an OSGi bundle), but 
rather with the underlying zookeeper bundle. The issue there is that ZK uses a 
dash in its versioning scheme (3.5.x-alpha or 3.5.3-beta) and that version 
becomes part of the `Bundle-Version` in the manifest file. OSGi versioning 
can't parse that dash; typically, in such situations the dash is replaced with 
a period for the `Bundle-Version` field in the manifest.
    
    As an experiment, I re-wrapped the ZK bundle (using the version 
3.5.3.beta). Then it became possible to deploy ZK 3.5 in Karaf, and once that 
was in place, all of the 4.0.0 Curator bundles could be both deployed and 
started in Karaf.
    
    TL;DR -- the Curator bundles are already in fine shape for OSGi, the issue 
is upstream with Zookeeper, which itself will be resolved as soon as the 
`-beta` is dropped from the version.


> OSGI bundles should not import org.apache.curator
> -------------------------------------------------
>
>                 Key: CURATOR-432
>                 URL: https://issues.apache.org/jira/browse/CURATOR-432
>             Project: Apache Curator
>          Issue Type: Bug
>            Reporter: Christopher Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>
> Curator bundles will not deploy to an OSGI container like Karaf with an 
> import requirement on a non-existent package.  The problem is highlighted in 
> the excerpt from the MANIFEST.MF below
> {code:java}
> Import-Package: com.google.common.base;version="[20.0,21)",com.google.
>  common.collect;version="[20.0,21)",com.google.common.util.concurrent;
>  version="[20.0,21)",*org.apache.curator;version="[4.0,5)"*,org.apache.c
>  urator.framework;version="[4.0,5)",org.apache.curator.framework.api;v
>  ersion="[4.0,5)",org.apache.curator.framework.api.transaction;version
>  ="[4.0,5)",org.apache.curator.framework.imps;version="[4.0,5)",org.ap
>  ache.curator.framework.listen;version="[4.0,5)",org.apache.curator.fr
>  amework.state;version="[4.0,5)",org.apache.curator.retry;version="[4.
>  0,5)",org.apache.curator.utils;version="[4.0,5)",org.apache.zookeeper
>  ;version="[3.5,4)",org.apache.zookeeper.data;version="[3.5,4)",org.sl
>  f4j;version="[1.7,2)"
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to