[
https://issues.apache.org/jira/browse/CURATOR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505713#comment-16505713
]
ASF GitHub Bot commented on CURATOR-470:
----------------------------------------
GitHub user JerryChin opened a pull request:
https://github.com/apache/curator/pull/265
Add new service cache listener to let users know what instances have …
This PR is for issue
[CURATOR-470](https://issues.apache.org/jira/projects/CURATOR/issues/CURATOR-470).
A new interface (`ServiceCacheEventListener`) is introduced to expose
changed instances, while preserving backward compatibility.
Unit test has updated as well.
@Randgalt Please help to review it, thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JerryChin/curator CURATOR-470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #265
----
commit 88e8d9a15d4f1690a6df1c1cabb355936f327aaa
Author: Qin Meijie <meijie.qin@...>
Date: 2018-06-08T05:06:15Z
Add new service cache listener to let users know what instances have
changed, while preserving backward compatibility.
----
> Newly added/Removed ServiceInstance should be passed to
> ServiceCacheListener#cacheChanged method
> -------------------------------------------------------------------------------------------------
>
> Key: CURATOR-470
> URL: https://issues.apache.org/jira/browse/CURATOR-470
> Project: Apache Curator
> Issue Type: Improvement
> Components: General, Recipes
> Affects Versions: 4.0.1
> Reporter: Jerry Chin
> Priority: Major
>
> Hey fellows,
> We're using _service discovery_ extension to refactor our raw zookeeper based
> service monitor.
> Every time a service instance exits or joins, the monitor must be notified
> and push a notification to us, the only thing I found in _service discovery_
> package meets the requirement is {{ServiceCacheListener}} interface, but when
> the interface is fired, there's no way we could know which service has
> changed.
> Please help !
> Thank in advance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
