[
https://issues.apache.org/jira/browse/CURATOR-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661755#comment-16661755
]
Stig Rohde Døssing edited comment on CURATOR-409 at 10/24/18 6:36 AM:
----------------------------------------------------------------------
I think backporting this to 2.x makes sense. People should be able to upgrade
to 4.x for the production Curator code, but if they're on Zookeeper 3.4.x,
they'll need to use the 2.x version of curator-test
(https://curator.apache.org/zk-compatibility.html). So people that are using
Curator 3.x should just be able to upgrade to 4.x, but Zookeeper 3.4.x users
will probably have this issue unless it's patched in curator-test 2.x.
was (Author: srdo):
I think backporting this to 2.x makes sense. People should be able to upgrade
to 4.x, but if they're on Zookeeper 3.4.x, they'll need to use the 2.x version
of curator-test (https://curator.apache.org/zk-compatibility.html). So people
that are using Curator 3.x should just be able to upgrade to 4.x, but Zookeeper
3.4.x users will probably have this issue unless it's patched in curator-test
2.x.
> TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta
> -------------------------------------------------------------
>
> Key: CURATOR-409
> URL: https://issues.apache.org/jira/browse/CURATOR-409
> Project: Apache Curator
> Issue Type: Bug
> Components: Tests
> Affects Versions: 3.3.0
> Reporter: Stig Rohde Døssing
> Priority: Major
> Fix For: 4.0.0
>
>
> Zookeeper 3.5.3 has added a getQuorumPeer method to QuorumPeerMain
> https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194.
> TestingQuorumPeerMain has an identically named method, which is now
> unintentionally overridding the one in the base class.
> This causes TestingCluster to be unusable.
> {code}
> 20:36:41.199 [Thread-1] ERROR org.apache.curator.test.TestingZooKeeperServer
> - From testing server (random state: false) for instance:
> InstanceSpec{dataDirectory=C:\Users\Esran\AppData\Local\Temp\1494009401090-0,
> port=65306, electionPort=65307, quorumPort=65308,
> deleteDataDirectoryOnClose=true, serverId=1, tickTime=-1, maxClientCnxns=-1,
> customProperties={}, hostname=127.0.0.1}
> org.apache.curator.test.InstanceSpec@59c4b497
> java.lang.NullPointerException: null
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:158)
>
> ~[zookeeper-3.5.3-beta.jar:3.5.3-beta-8ce24f9e675cbefffb8f21a47e06b42864475a60]
> at
> org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:150)
> [curator-test-3.3.0.jar:3.3.0]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_73]
> {code}
> The method in TestingQuorumPeerMain should be renamed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
