Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r233243506
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -445,7 +445,8 @@ private void createNode()
try
{
String existingPath = nodePath.get();
- String createPath = (existingPath != null && !useProtection) ?
existingPath : basePath;
+ String createPath = existingPath == null || (useProtection &&
!isSequential(mode)) ? basePath
+ : (useProtection ? basePath +
existingPath.substring(existingPath.length()-10) : existingPath);
--- End diff --
@Randgalt @cammckenzie sure, I can do that but am wondering about the best
semantics for such a utility method. In particular should it first verify that
the path ends in 10 digits? (even in the case that it does, I don't think it's
guaranteed to be a sequential node). If so and it does not end in 10 digits,
what should be the behaviour?
For this scenario in `PersistentNode` we can be "sure" that it's sequential
and hence it's probably reasonable (and more efficient) to omit the check.
Given that curator has lasted this long without the need for such a method, I'm
wondering whether having it is really warranted. Might it be better to wait
until N > 1 (if that ever happens)?
---
