[
https://issues.apache.org/jira/browse/CURATOR-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713731#comment-16713731
]
ASF GitHub Bot commented on CURATOR-480:
----------------------------------------
GitHub user Hendrik-H opened a pull request:
https://github.com/apache/curator/pull/287
[CURATOR-480] fixed ModeledFrameworkImpl.delete version handling
using the passed in version in ModeledFrameworkImpl.delete
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hendrik-H/curator CURATOR-480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit 6a9c6ab6757158d50d00bedfdd95582aa4554fc3
Author: Hendrik Haddorp <hendrik.haddorp@...>
Date: 2018-12-08T16:11:02Z
fixed the version handling,
https://issues.apache.org/jira/browse/CURATOR-480
----
> org.apache.curator.x.async.modeled.details.ModeledFrameworkImpl.delete(int)
> is not using version parameter
> ----------------------------------------------------------------------------------------------------------
>
> Key: CURATOR-480
> URL: https://issues.apache.org/jira/browse/CURATOR-480
> Project: Apache Curator
> Issue Type: Bug
> Reporter: Hendrik Haddorp
> Assignee: Jordan Zimmerman
> Priority: Major
>
> org.apache.curator.x.async.modeled.details.ModeledFrameworkImpl.delete(int)
> is defined as:
> public AsyncStage<Void> delete(int version)
> {
> return
> dslClient.delete().withVersion(-1).forPath(modelSpec.path().fullPath());
> }
> Shouldn't the -1 be "version"?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
