shayshim commented on a change in pull request #311: [CURATOR-429] Make Curator 
4.x compatible with Zookeeper 3.4.x in OSGi too
URL: https://github.com/apache/curator/pull/311#discussion_r283473432
 
 

 ##########
 File path: curator-client/pom.xml
 ##########
 @@ -36,7 +36,7 @@
 
     <properties>
         <osgi.import.package>
-            *
+            org.apache.zookeeper.*;version="[3.4,4.0)", *
 
 Review comment:
   I have no background with OSGi. Could you explain this change? I mean, why 
"osgi.import.package" with '*' didn't do what you need and this change fixes 
it? Usually '*' is most general. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to