pacomendes commented on a change in pull request #312: Compilation on jdk11 for
release 8
URL: https://github.com/apache/curator/pull/312#discussion_r286087717
##########
File path: pom.xml
##########
@@ -668,6 +669,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
+ <release>${jdk-release-version}</release>
<source>${jdk-version}</source>
<target>${jdk-version}</target>
Review comment:
source and target can be removed when switching to jdk11. Currently this
would cause compilation to fail on jdk8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
