[
https://issues.apache.org/jira/browse/CURATOR-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021068#comment-17021068
]
Roelof Naude commented on CURATOR-557:
--------------------------------------
maybe i missed something here:
ServiceCacheImpl(ServiceDiscoveryImpl<T> discovery, String name, ThreadFactory
threadFactory) -> convertThreadFactory(threadFactory) -> new
CloseableExecutorService(Executors.newSingleThreadExecutor(threadFactory))
PathChildrenCache receives the CloseableExecutorService with shutdownOnClose =
false, thus not closing the executor?
> ServiceCacheImpl does not close ExecutorService
> -----------------------------------------------
>
> Key: CURATOR-557
> URL: https://issues.apache.org/jira/browse/CURATOR-557
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.2.0
> Reporter: Roelof Naude
> Priority: Major
>
> ServiceCacheImpl does not close the ExecutorService instance created from the
> ThreadFactory:
> [https://github.com/apache/curator/blob/master/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java#L64]
>
> CloseableExecutorService::CloseableExecutorService(ExecutorService) call
> this(executorService, false) which sets shutdownOnClose to false.
>
> this has an impact from callers, eg ServiceProviderImpl, which only allow
> only a ThreadFactory to be specified.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
