[
https://issues.apache.org/jira/browse/CURATOR-557?focusedWorklogId=379040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379040
]
ASF GitHub Bot logged work on CURATOR-557:
------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/20 21:50
Start Date: 29/Jan/20 21:50
Worklog Time Spent: 10m
Work Description: shayshim commented on pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r372648860
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceCacheBuilder.java
##########
@@ -46,6 +46,7 @@
* @param threadFactory factory
* @return this
*/
Review comment:
Also, it turns out that deprecation of interface method doesn't affect
overriding methods, as said in the same link:
"It is possible for a non-deprecated property to hide or override a
deprecated one, which removes deprecation. As developer of an API, it is your
responsibility to deprecate overrides of a deprecated method, if in fact they
should be deprecated."
Could you deprecate also the two `threadFactory(...)` overriding methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379040)
Time Spent: 2h (was: 1h 50m)
> ServiceCacheImpl does not close ExecutorService
> -----------------------------------------------
>
> Key: CURATOR-557
> URL: https://issues.apache.org/jira/browse/CURATOR-557
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.2.0
> Reporter: Roelof Naude
> Priority: Major
> Attachments: CURATOR-557.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> ServiceCacheImpl does not close the ExecutorService instance created from the
> ThreadFactory:
> [https://github.com/apache/curator/blob/master/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java#L64]
>
> CloseableExecutorService::CloseableExecutorService(ExecutorService) call
> this(executorService, false) which sets shutdownOnClose to false.
>
> this has an impact from callers, eg ServiceProviderImpl, which only allow
> only a ThreadFactory to be specified.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
