TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK
3.6 updates
URL: https://github.com/apache/curator/pull/344#discussion_r392621920
##########
File path:
curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestTreeCache.java
##########
@@ -423,9 +423,9 @@ public void testKilledSession() throws Exception
client.create().withMode(CreateMode.EPHEMERAL).forPath("/test/me",
"data".getBytes());
assertEvent(TreeCacheEvent.Type.NODE_ADDED, "/test/me");
-
Compatibility.injectSessionExpiration(client.getZookeeperClient().getZooKeeper());
- assertEvent(TreeCacheEvent.Type.NODE_REMOVED, "/test/me",
"data".getBytes(), true);
+
client.getZookeeperClient().getZooKeeper().getTestable().injectSessionExpiration();
assertEvent(TreeCacheEvent.Type.INITIALIZED, null, null, true);
+ assertEvent(TreeCacheEvent.Type.NODE_REMOVED, "/test/me",
"data".getBytes(), true);
Review comment:
Interesting. The different is that zookeeper's testable has these additional
lines
```java
this.clientCnxn.eventThread.queueEventOfDeath();
this.clientCnxn.state = States.CLOSED;
this.clientCnxn.sendThread.getClientCnxnSocket().onClosing();
```
where both of them calls
```java
this.clientCnxn.eventThread.queueEvent(new WatchedEvent(EventType.None,
KeeperState.Expired, (String)null));
```
I'm not very sure how it changes the behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
