[
https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403536
]
ASF GitHub Bot logged work on CURATOR-549:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/20 04:47
Start Date: 15/Mar/20 04:47
Worklog Time Spent: 10m
Work Description: TisonKun commented on pull request #338: [CURATOR-549]
Prep for Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r392640142
##########
File path:
curator-client/src/main/java/org/apache/curator/utils/Compatibility.java
##########
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.curator.utils;
+
+import org.apache.zookeeper.server.quorum.QuorumPeer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.net.InetSocketAddress;
+
+/**
+ * Utils to help with ZK version compatibility
+ */
+public class Compatibility
+{
+ private static final Method getReachableOrOneMethod;
+ private static final Field addrField;
+
+ private static final Logger logger =
LoggerFactory.getLogger(Compatibility.class);
+
+ static
+ {
+ Method localGetReachableOrOneMethod;
+ try
+ {
+ Class<?> multipleAddressesClass =
Class.forName("org.apache.zookeeper.server.quorum.MultipleAddresses");
+ localGetReachableOrOneMethod =
multipleAddressesClass.getMethod("getReachableOrOne");
+ LoggerFactory.getLogger(Compatibility.class).info("Using
org.apache.zookeeper.server.quorum.MultipleAddresses");
+ }
+ catch ( ReflectiveOperationException ignore )
+ {
+ localGetReachableOrOneMethod = null;
+ }
+ getReachableOrOneMethod = localGetReachableOrOneMethod;
+
+ Field localAddrField;
+ try
+ {
+ localAddrField = QuorumPeer.QuorumServer.class.getField("addr");
+ }
+ catch ( NoSuchFieldException e )
+ {
+ localAddrField = null;
+ LoggerFactory.getLogger(Compatibility.class).error("Could not get
addr field! Reconfiguration fail!");
Review comment:
```suggestion
logger.error("Could not get addr field! Reconfiguration fail!");
```
And most where in Curator we call the logger `log`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403536)
Time Spent: 7h (was: 6h 50m)
> ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add
> Curator support
> --------------------------------------------------------------------------------------
>
> Key: CURATOR-549
> URL: https://issues.apache.org/jira/browse/CURATOR-549
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Recipes, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Major
> Fix For: 5.0.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> ZOOKEEPER-1416 will add support for Persistent Recursive Watchers. This
> feature allows Curator to re-think/re-write the various cache recipes so that
> they're simpler, use less resources and more stable.
> * Change Curator to depend on ZooKeeper 3.6.x
> * Add a new module so that backward compatibility with 3.5 is ensured
> * Add new methods corresponding to {{ZooKeeper.addWatch()}}
> * Add a new recipe that enables a fully managed Persistent watch
> * Create new Cache recipes that use the new Persistent watch recipe
> * Replace internal usages of TreeCache/PathChildrenCache/NodeCache with new
> cache recipe
> * Deprecate TreeCache/PathChildrenCache/NodeCache
> * Updated docs/tests/etc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
