[
https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=416033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416033
]
ASF GitHub Bot logged work on CURATOR-549:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/20 22:06
Start Date: 04/Apr/20 22:06
Worklog Time Spent: 10m
Work Description: shayshim commented on pull request #336: [CURATOR-549]
Bridge facade for ModeledCache and ServiceCache, etc.
URL: https://github.com/apache/curator/pull/336#discussion_r403535987
##########
File path:
curator-x-async/src/main/java/org/apache/curator/x/async/modeled/details/ModeledCacheImpl.java
##########
@@ -42,11 +46,12 @@
class ModeledCacheImpl<T> implements TreeCacheListener, ModeledCache<T>
{
- private final TreeCache cache;
+ private final CuratorCacheBridge cache;
private final Map<ZPath, Entry<T>> entries = new ConcurrentHashMap<>();
private final ModelSerializer<T> serializer;
private final StandardListenerManager<ModeledCacheListener<T>>
listenerContainer = StandardListenerManager.standard();
private final ZPath basePath;
+ private final EnsureContainers ensureContainers;
Review comment:
This is more question for the previous review, but why `TreeCache` support
creating the parent nodes of the path (as containers) and `CuratorCache` isn't?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 416033)
Time Spent: 18h 40m (was: 18.5h)
> ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add
> Curator support
> --------------------------------------------------------------------------------------
>
> Key: CURATOR-549
> URL: https://issues.apache.org/jira/browse/CURATOR-549
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Recipes, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Major
> Fix For: 5.0.0
>
> Time Spent: 18h 40m
> Remaining Estimate: 0h
>
> ZOOKEEPER-1416 will add support for Persistent Recursive Watchers. This
> feature allows Curator to re-think/re-write the various cache recipes so that
> they're simpler, use less resources and more stable.
> * Change Curator to depend on ZooKeeper 3.6.x
> * Add a new module so that backward compatibility with 3.5 is ensured
> * Add new methods corresponding to {{ZooKeeper.addWatch()}}
> * Add a new recipe that enables a fully managed Persistent watch
> * Create new Cache recipes that use the new Persistent watch recipe
> * Replace internal usages of TreeCache/PathChildrenCache/NodeCache with new
> cache recipe
> * Deprecate TreeCache/PathChildrenCache/NodeCache
> * Updated docs/tests/etc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
