Randgalt commented on a change in pull request #336: [CURATOR-549] Bridge
facade for ModeledCache and ServiceCache, etc.
URL: https://github.com/apache/curator/pull/336#discussion_r405932562
##########
File path:
curator-x-async/src/main/java/org/apache/curator/x/async/modeled/details/ModeledCacheImpl.java
##########
@@ -148,38 +165,32 @@ public void childEvent(CuratorFramework client,
TreeCacheEvent event)
}
}
- private void internalChildEvent(TreeCacheEvent event) throws Exception
+ private void internalChildEvent(TreeCacheEvent event)
Review comment:
> but in case of CuratorCache, it can be called only on the event thread
No, it isn't. Listeners are called via `client.runSafe(() ->
listenerManager.forEach(proc));`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
