[
https://issues.apache.org/jira/browse/CURATOR-574?focusedWorklogId=449063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449063
]
ASF GitHub Bot logged work on CURATOR-574:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:06
Start Date: 22/Jun/20 08:06
Worklog Time Spent: 10m
Work Description: eolivelli commented on pull request #367:
URL: https://github.com/apache/curator/pull/367#issuecomment-647356586
@Randgalt
the patch is finally ready for review.
I have added a few assertions on an existing test.
With this fix the errors on CURATOR-574 are not present anymore.
I wonder if it is better to rename the issue, actually this was a problem on
PathChildrenCacheListenerWrapper.java and not in ServiceDiscovery.
The change is not backward compatibile, but it is on a fresh new API of
Curator 5.0, so if you release 5.0.1 (or 5.1 if you want to strictly observe
SemVer) it won't be a big deal
I can create the 5.0.1 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 449063)
Time Spent: 2h 20m (was: 2h 10m)
> DiscoveryService fatal error on deserializing an empty byte[] as JSON
> ---------------------------------------------------------------------
>
> Key: CURATOR-574
> URL: https://issues.apache.org/jira/browse/CURATOR-574
> Project: Apache Curator
> Issue Type: Bug
> Components: Recipes
> Affects Versions: 5.0.0
> Reporter: Enrico Olivelli
> Priority: Critical
> Fix For: 5.1.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Below you can see the error in 5.0.0 tests, but I have seen this error on a
> client application. The error seems a blocker for the upgrade to 5.0.0
> {code}
> ERROR org.apache.curator.framework.listen.MappingListenerManager Listener
> (org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2@329dbdbf)
> threw an exception [Curator-SafeNotifyService-0]
> java.lang.RuntimeException: java.lang.RuntimeException:
> com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to
> map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.sendEvent(PathChildrenCacheListenerWrapper.java:75)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.event(PathChildrenCacheListenerWrapper.java:42)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2.lambda$event$0(CuratorCacheListenerBuilderImpl.java:149)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2.event(CuratorCacheListenerBuilderImpl.java:149)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheImpl.lambda$putStorage$7(CuratorCacheImpl.java:279)
> at
> org.apache.curator.framework.listen.MappingListenerManager.lambda$forEach$0(MappingListenerManager.java:92)
> at
> org.apache.curator.framework.listen.MappingListenerManager.forEach(MappingListenerManager.java:89)
> at
> org.apache.curator.framework.listen.StandardListenerManager.forEach(StandardListenerManager.java:89)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheImpl.lambda$callListeners$10(CuratorCacheImpl.java:293)
> at
> java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1800)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
> at java.base/java.lang.Thread.run(Thread.java:832)
> Caused by: java.lang.RuntimeException:
> com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to
> map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.addInstance(ServiceCacheImpl.java:209)
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.childEvent(ServiceCacheImpl.java:175)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.sendEvent(PathChildrenCacheListenerWrapper.java:71)
> ... 13 more
> Caused by: com.fasterxml.jackson.databind.exc.MismatchedInputException: No
> content to map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> com.fasterxml.jackson.databind.exc.MismatchedInputException.from(MismatchedInputException.java:59)
> at
> com.fasterxml.jackson.databind.ObjectMapper._initForReading(ObjectMapper.java:4344)
> at
> com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4189)
> at
> com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3300)
> at
> org.apache.curator.x.discovery.details.JsonInstanceSerializer.deserialize(JsonInstanceSerializer.java:86)
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.addInstance(ServiceCacheImpl.java:204)
> ... 15 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
