pboutes commented on a change in pull request #380:
URL: https://github.com/apache/curator/pull/380#discussion_r589537744



##########
File path: 
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
##########
@@ -72,9 +72,11 @@
     private final long ttl;
     private final AtomicReference<byte[]> data = new AtomicReference<byte[]>();
     private final AtomicReference<State> state = new 
AtomicReference<State>(State.LATENT);
-    private final AtomicBoolean authFailure = new AtomicBoolean(false);
+    private volatile boolean authFailure;
+    private volatile boolean parentCreationFailure;
     private final BackgroundCallback backgroundCallback;
     private final boolean useProtection;
+    private final boolean useParentCreation;

Review comment:
       Yeah I wanted to be consistent with the other naming, but I'm not 
opposed to named it `creatingParentContainersIfNeeded`. But what 
`useProtection` should be?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to