Could someone please review my PR? More than a month passed with no feedback at all :(
I appreciate it if someone helps with progressing this so it can be merged. Thanks, Gelbana On Sat, May 8, 2021 at 12:37 AM Muhammad Gelbana <[email protected]> wrote: > I create a PR and added a couple of comments on the ticket a while ago. > Would someone kindly go through my comments and review my PR? > Here is the Jira for your convenience > https://issues.apache.org/jira/browse/CURATOR-592 > > Thanks, > Gelbana > > > On Thu, Apr 22, 2021 at 8:30 AM Enrico Olivelli <[email protected]> > wrote: > >> Il giorno gio 22 apr 2021 alle ore 00:20 Muhammad Gelbana >> <[email protected]> ha scritto: >> > >> > Thanks a lot Cameron and excuse me for the delay to work on this! >> > >> > One thing that is confusing me now is the java version used for >> development >> > as this page >> > < >> https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests >> > >> > says it's Java 6 while I already see lambda expressions in the code base >> > such as this one >> > < >> https://github.com/apache/curator/blob/15a9f03f6f7b156806d05d0dd7ce6cfd3ef39c72/curator-client/src/main/java/org/apache/curator/RetryLoop.java#L86 >> > >> > . >> > I guess I can use Java 8 but I just wanted to confirm if that's alright. >> >> Java 8 >> I have updated the page, thanks for the feedback >> >> Enrico >> >> > >> > Thanks, >> > Gelbana >> > >> > >> > On Sun, Mar 14, 2021 at 11:52 PM Cameron McKenzie < >> [email protected]> >> > wrote: >> > >> > > hey Gelbana, >> > > Sounds like a reasonable proposal to me. I would be happy to help you >> > > through the process if you would like to raise a PR with an >> implementation >> > > and tests. >> > > cheers >> > > >> > > On Sun, Mar 14, 2021 at 11:19 PM Muhammad Gelbana < >> [email protected]> >> > > wrote: >> > > >> > > > Hello everyone, >> > > > >> > > > I appreciate it if someone checks this improvement >> > > > <https://issues.apache.org/jira/browse/CURATOR-592> and add a >> comment if >> > > > necessary. I'm planning to implement this change and your feedback >> is >> > > very >> > > > much needed. >> > > > >> > > > Thanks, >> > > > Gelbana >> > > > >> > > >> >
