[
https://issues.apache.org/jira/browse/CURATOR-599?focusedWorklogId=620768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620768
]
ASF GitHub Bot logged work on CURATOR-599:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/21 22:48
Start Date: 08/Jul/21 22:48
Worklog Time Spent: 10m
Work Description: cammckenzie commented on a change in pull request #391:
URL: https://github.com/apache/curator/pull/391#discussion_r666537811
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java
##########
@@ -1070,10 +1077,28 @@ public void testCreateModes() throws Exception
stat = client.checkExists().forPath(realPath);
assertNull(stat);
+
Review comment:
Break this off into a new unit test. It's got nothing to do with testing
create modes.
##########
File path:
curator-client/src/main/java/org/apache/curator/utils/ConfigurableZookeeperFactory.java
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.curator.utils;
+
+import org.apache.zookeeper.Watcher;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.admin.ZooKeeperAdmin;
+import org.apache.zookeeper.client.ZKClientConfig;
+
+/**
+ * Configurable ZookeeperFactory, by using
org.apache.zookeeper.client.ZKClientConfig.
+ *
+ * @author Liran Mendelovich
Review comment:
We don't use @Author annotations (not sure why exactly, just history).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 620768)
Time Spent: 1h 40m (was: 1.5h)
> Hanging indefinitely on some scenarios since zookeeper.request.timeout cannot
> be configured
> -------------------------------------------------------------------------------------------
>
> Key: CURATOR-599
> URL: https://issues.apache.org/jira/browse/CURATOR-599
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client
> Affects Versions: 5.1.0
> Reporter: Liran Mendelovich
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> On some executions where ZooKeeper server is not available, Curator client
> got waiting and hanging indefinitely, with thread dump stack trace which can
> be seen
> below.
> As this is not reproduced consistently, it seems like a race condition from
> Curator/ZooKeeper client, since zookeeper.request.timeout cannot be
> configured in Curator client.
> As a work-around solution, initialization is executed in a separate thread in
> order to interrupt it if it hangs. This has been identified and handled here:
> [join_while_zookeeper_down_issue|https://github.com/CiscoSE/commons-cluster/blob/main/docs/join_while_zookeeper_down_issue.txt]
> The wanted solution is expose configuration to be able to configure
> zookeeper.request.timeout, then it should wait until the request timeout,
> which is treated at org.apache.zookeeper.ClientCnxn.submitRequest().
>
> stacktrace size: 31
> java.lang.Object.wait(Native Method)
> java.lang.Object.wait(Object.java:502)
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1561)
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1533)
> org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1834)
> org.apache.curator.framework.imps.CreateBuilderImpl$16.call(CreateBuilderImpl.java:1131)
> org.apache.curator.framework.imps.CreateBuilderImpl$16.call(CreateBuilderImpl.java:1113)
> org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:93)
> org.apache.curator.framework.imps.CreateBuilderImpl.pathInForeground(CreateBuilderImpl.java:1110)
> org.apache.curator.framework.imps.CreateBuilderImpl.protectedPathInForeground(CreateBuilderImpl.java:593)
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:583)
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:48)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.internalRegisterService(ServiceDiscoveryImpl.java:237)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.reRegisterServices(ServiceDiscoveryImpl.java:456)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.start(ServiceDiscoveryImpl.java:135)
> ...
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
